You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Laurent Pinchart f41ced8f10 Check fops_get() return value ... Several subsystem open handlers dereference the fops_get() return value without checking it for nullness. This opens a race condition between the open handler and module unloading. A module can be marked as being unloaded (MODULE_STATE_GOING) before its exit function is called and gets the chance to unregister the driver. During that window open handlers can still be called, and fops_get() will fail in try_module_get() and return a NULL pointer. This change checks the fops_get() return value and returns -ENODEV if NULL. Reported-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk> Signed-off-by: Laurent Pinchart <laurent.pinchart@skynet.be> Acked-by: Takashi Iwai <tiwai@suse.de> Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: Dave Airlie <airlied@linux.ie> Acked-by: Mauro Carvalho Chehab <mchehab@infradead.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		16 years ago
..
oss	[PATCH] introduce fmode_t, do annotations	16 years ago
seq	ALSA: Add hrtimer backend for ALSA timer interface	16 years ago
Kconfig	ALSA: Fix a typo in Kconfig	16 years ago
Makefile	ALSA: Add hrtimer backend for ALSA timer interface	16 years ago
control.c	saner FASYNC handling on file close	16 years ago
control_compat.c	ALSA: Kill snd_assert() in sound/core/*	17 years ago
device.c	ALSA: Print function symbol in the error messages	16 years ago
hrtimer.c	Merge branch 'timers-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip	16 years ago
hwdep.c	ALSA: Kill snd_assert() in sound/core/*	17 years ago
hwdep_compat.c	…
info.c	ALSA: when card identification is changed, change also /proc/asound symlink	16 years ago
info_oss.c	ALSA: Kill snd_assert() in sound/core/*	17 years ago
init.c	sound: Fix warnings relating to ignored return value in snd_card_register	16 years ago
isadma.c	…
jack.c	Merge branch 'topic/jack-mechanical' into to-push	16 years ago
memalloc.c	Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/torvalds/linux-2.6	16 years ago
memory.c	…
misc.c	…
pcm.c	ALSA: Kill snd_assert() in sound/core/*	17 years ago
pcm_compat.c	ALSA: Kill snd_assert() in sound/core/*	17 years ago
pcm_lib.c	ALSA: kernel docs: fix sound/core/ kernel-doc	16 years ago
pcm_memory.c	ALSA: Allocate larger pages in sgbuf	17 years ago
pcm_misc.c	sound: add missing pcm kernel-doc	16 years ago
pcm_native.c	saner FASYNC handling on file close	16 years ago
pcm_timer.c	ALSA: Kill snd_assert() in sound/core/*	17 years ago
rawmidi.c	ALSA: hda - Convert from takslet_hi_schedule() to tasklet_schedule()	16 years ago
rawmidi_compat.c	…
rtctimer.c	ALSA: hda - Convert from takslet_hi_schedule() to tasklet_schedule()	16 years ago
sgbuf.c	ALSA: Allocate larger pages in sgbuf	17 years ago
sound.c	Check fops_get() return value	16 years ago
sound_oss.c	ALSA: Kill snd_assert() in sound/core/*	17 years ago
timer.c	ALSA: hda - Convert from takslet_hi_schedule() to tasklet_schedule()	16 years ago
timer_compat.c	ALSA: Kill snd_assert() in sound/core/*	17 years ago
vmaster.c	…