You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Vasily Averin 5a2b4062f5 [PATCH] ext2: errors behaviour fix ... Current error behaviour for ext2 and ext3 filesystems does not fully correspond to the documentation and should be fixed. According to man 8 mount, ext2 and ext3 file systems allow to set one of 3 different on-errors behaviours: ---- start of quote man 8 mount ---- errors=continue / errors=remount-ro / errors=panic Define the behaviour when an error is encountered. (Either ignore errors and just mark the file system erroneous and continue, or remount the file system read-only, or panic and halt the system.) The default is set in the filesystem superblock, and can be changed using tune2fs(8). ---- end of quote ---- However EXT3_ERRORS_CONTINUE is not read from the superblock, and thus ERRORS_CONT is not saved on the sbi->s_mount_opt. It leads to the incorrect handle of errors on ext3. Then we've checked corresponding code in ext2 and discovered that it is buggy as well: - EXT2_ERRORS_CONTINUE is not read from the superblock (the same); - parse_option() does not clean the alternative values and thus something like (ERRORS_CONT|ERRORS_RO) can be set; - if options are omitted, parse_option() does not set any of these options. Therefore it is possible to set any combination of these options on the ext2: - none of them may be set: EXT2_ERRORS_CONTINUE on superblock / empty mount options; - any of them may be set using mount options; - 2 any options may be set: by using EXT2_ERRORS_RO/EXT2_ERRORS_PANIC on the superblock and other value in mount options; - and finally all three options may be set by adding third option in remount. Currently ext2 uses these values only in ext2_error() and it is not leading to any noticeable troubles. However somebody may be discouraged when he will try to workaround EXT2_ERRORS_PANIC on the superblock by using errors=continue in mount options. This patch: EXT2_ERRORS_CONTINUE should be read from the superblock as default value for error behaviour. parse_option() should clean the alternative options and should not change default value taken from the superblock. Signed-off-by: Vasily Averin <vvs@sw.ru> Acked-by: Kirill Korotaev <dev@openvz.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>		19 years ago
..
Makefile	[PATCH] Make EXT2_DEBUG work again	19 years ago
acl.c	[PATCH] fs: Removing useless casts	19 years ago
acl.h	…
balloc.c	[PATCH] EXT2: Remove superblock lock contention in ext2_statfs	19 years ago
dir.c	[PATCH] BLOCK: Move the Ext2 device ioctl compat stuff to the Ext2 driver [try #6]	19 years ago
ext2.h	[PATCH] BLOCK: Move the Ext2 device ioctl compat stuff to the Ext2 driver [try #6]	19 years ago
file.c	[PATCH] Streamline generic_file_* interfaces and filemap cleanups	19 years ago
fsync.c	[PATCH] ext2: cleanup: put_page and comment fix	19 years ago
ialloc.c	[PATCH] inode-diet: Eliminate i_blksize from the inode structure	19 years ago
inode.c	[PATCH] inode-diet: Eliminate i_blksize from the inode structure	19 years ago
ioctl.c	[PATCH] BLOCK: Move the Ext2 device ioctl compat stuff to the Ext2 driver [try #6]	19 years ago
namei.c	[PATCH] r/o bind mounts: unlink: monitor i_nlink	19 years ago
super.c	[PATCH] ext2: errors behaviour fix	19 years ago
symlink.c	…
xattr.c	[PATCH] fs: Conversions from kmalloc+memset to k(z|c)alloc	19 years ago
xattr.h	Remove obsolete #include <linux/config.h>	19 years ago
xattr_security.c	…
xattr_trusted.c	[PATCH] capable/capability.h (fs/)	19 years ago
xattr_user.c	[PATCH] remove ext2 xattr permission checks	19 years ago
xip.c	…
xip.h	…