You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Andrea Righi 27ac792ca0 PAGE_ALIGN(): correctly handle 64-bit values on 32-bit architectures ... On 32-bit architectures PAGE_ALIGN() truncates 64-bit values to the 32-bit boundary. For example: u64 val = PAGE_ALIGN(size); always returns a value < 4GB even if size is greater than 4GB. The problem resides in PAGE_MASK definition (from include/asm-x86/page.h for example): #define PAGE_SHIFT 12 #define PAGE_SIZE (_AC(1,UL) << PAGE_SHIFT) #define PAGE_MASK (~(PAGE_SIZE-1)) ... #define PAGE_ALIGN(addr) (((addr)+PAGE_SIZE-1)&PAGE_MASK) The "~" is performed on a 32-bit value, so everything in "and" with PAGE_MASK greater than 4GB will be truncated to the 32-bit boundary. Using the ALIGN() macro seems to be the right way, because it uses typeof(addr) for the mask. Also move the PAGE_ALIGN() definitions out of include/asm-*/page.h in include/linux/mm.h. See also lkml discussion: http://lkml.org/lkml/2008/6/11/237 [akpm@linux-foundation.org: fix drivers/media/video/uvc/uvc_queue.c] [akpm@linux-foundation.org: fix v850] [akpm@linux-foundation.org: fix powerpc] [akpm@linux-foundation.org: fix arm] [akpm@linux-foundation.org: fix mips] [akpm@linux-foundation.org: fix drivers/media/video/pvrusb2/pvrusb2-dvb.c] [akpm@linux-foundation.org: fix drivers/mtd/maps/uclinux.c] [akpm@linux-foundation.org: fix powerpc] Signed-off-by: Andrea Righi <righi.andrea@gmail.com> Cc: <linux-arch@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		17 years ago
..
boot	powerpc/boot: Change spaces to tabs	17 years ago
configs	powerpc/ps3: Update ps3_defconfig	17 years ago
kernel	PAGE_ALIGN(): correctly handle 64-bit values on 32-bit architectures	17 years ago
kvm	KVM: MMU: nuke shadowed pgtable pages and ptes on memslot destruction	17 years ago
lib	PAGE_ALIGN(): correctly handle 64-bit values on 32-bit architectures	17 years ago
math-emu	powerpc: Add macros to access floating point registers in thread_struct.	17 years ago
mm	powerpc: support multiple hugepage sizes	17 years ago
oprofile	on_each_cpu(): kill unused 'retry' parameter	17 years ago
platforms	spufs: use new vm_ops->access to allow local state access from gdb	17 years ago
sysdev	powerpc/dma: Use the struct dma_attrs in iommu code	17 years ago
xmon	Merge branch 'linux-2.6'	17 years ago
.gitignore	…
Kconfig	powerpc ioremap_prot	17 years ago
Kconfig.debug	kgdb, powerpc: arch specific powerpc kgdb support	17 years ago
Makefile	powerpc/bootwrapper: Add documentation of boot wrapper targets	17 years ago