You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Andrea Righi 27ac792ca0 PAGE_ALIGN(): correctly handle 64-bit values on 32-bit architectures ... On 32-bit architectures PAGE_ALIGN() truncates 64-bit values to the 32-bit boundary. For example: u64 val = PAGE_ALIGN(size); always returns a value < 4GB even if size is greater than 4GB. The problem resides in PAGE_MASK definition (from include/asm-x86/page.h for example): #define PAGE_SHIFT 12 #define PAGE_SIZE (_AC(1,UL) << PAGE_SHIFT) #define PAGE_MASK (~(PAGE_SIZE-1)) ... #define PAGE_ALIGN(addr) (((addr)+PAGE_SIZE-1)&PAGE_MASK) The "~" is performed on a 32-bit value, so everything in "and" with PAGE_MASK greater than 4GB will be truncated to the 32-bit boundary. Using the ALIGN() macro seems to be the right way, because it uses typeof(addr) for the mask. Also move the PAGE_ALIGN() definitions out of include/asm-*/page.h in include/linux/mm.h. See also lkml discussion: http://lkml.org/lkml/2008/6/11/237 [akpm@linux-foundation.org: fix drivers/media/video/uvc/uvc_queue.c] [akpm@linux-foundation.org: fix v850] [akpm@linux-foundation.org: fix powerpc] [akpm@linux-foundation.org: fix arm] [akpm@linux-foundation.org: fix mips] [akpm@linux-foundation.org: fix drivers/media/video/pvrusb2/pvrusb2-dvb.c] [akpm@linux-foundation.org: fix drivers/mtd/maps/uclinux.c] [akpm@linux-foundation.org: fix powerpc] Signed-off-by: Andrea Righi <righi.andrea@gmail.com> Cc: <linux-arch@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		17 years ago
..
amiga	PAGE_ALIGN(): correctly handle 64-bit values on 32-bit architectures	17 years ago
apollo	m68k: missing __init	18 years ago
atari	m68k/atari/debug.c: possible cleanups	17 years ago
bvme6000	bvme6000-rtc: BKL pushdown	17 years ago
configs	m68k: enable CONFIG_COMPAT_BRK by default	17 years ago
fpsp040	Stringify support commas	17 years ago
hp300	m68k: kill arch/m68k/hp300/ksyms.c	17 years ago
ifpsp060	Stringify support commas	17 years ago
kernel	m68k/apollo: Add missing call to apollo_parse_bootinfo()	17 years ago
lib	Stringify support commas	17 years ago
mac	m68k/mac/: possible cleanups	17 years ago
math-emu	Stringify support commas	17 years ago
mm	mm: drop unneeded pgdat argument from free_area_init_node()	17 years ago
mvme16x	mvme16x-rtc: BKL pushdown	17 years ago
mvme147	m68k: missing __init	18 years ago
q40	m68k/q40/config.c: make functions static	17 years ago
sun3	m68k/sun3/: possible cleanups	17 years ago
sun3x	m68k: missing __init	18 years ago
tools/amiga	Convert files to UTF-8 and some cleanups	17 years ago
Kconfig	m68k/Atari: remove the dead ATARI_SCC{,_DMA} options	17 years ago
Kconfig.debug	…
Makefile	m68k: make multi_defconfig the default defconfig	17 years ago