License cleanup: add SPDX GPL-2.0 license identifier to files with no license
Many source files in the tree are missing licensing information, which
makes it harder for compliance tools to determine the correct license.
By default all files without license information are under the default
license of the kernel, which is GPL version 2.
Update the files which contain no license information with the 'GPL-2.0'
SPDX license identifier. The SPDX identifier is a legally binding
shorthand, which can be used instead of the full boiler plate text.
This patch is based on work done by Thomas Gleixner and Kate Stewart and
Philippe Ombredanne.
How this work was done:
Patches were generated and checked against linux-4.14-rc6 for a subset of
the use cases:
- file had no licensing information it it.
- file was a */uapi/* one with no licensing information in it,
- file was a */uapi/* one with existing licensing information,
Further patches will be generated in subsequent months to fix up cases
where non-standard license headers were used, and references to license
had to be inferred by heuristics based on keywords.
The analysis to determine which SPDX License Identifier to be applied to
a file was done in a spreadsheet of side by side results from of the
output of two independent scanners (ScanCode & Windriver) producing SPDX
tag:value files created by Philippe Ombredanne. Philippe prepared the
base worksheet, and did an initial spot review of a few 1000 files.
The 4.13 kernel was the starting point of the analysis with 60,537 files
assessed. Kate Stewart did a file by file comparison of the scanner
results in the spreadsheet to determine which SPDX license identifier(s)
to be applied to the file. She confirmed any determination that was not
immediately clear with lawyers working with the Linux Foundation.
Criteria used to select files for SPDX license identifier tagging was:
- Files considered eligible had to be source code files.
- Make and config files were included as candidates if they contained >5
lines of source
- File already had some variant of a license header in it (even if <5
lines).
All documentation files were explicitly excluded.
The following heuristics were used to determine which SPDX license
identifiers to apply.
- when both scanners couldn't find any license traces, file was
considered to have no license information in it, and the top level
COPYING file license applied.
For non */uapi/* files that summary was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 11139
and resulted in the first patch in this series.
If that file was a */uapi/* path one, it was "GPL-2.0 WITH
Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 WITH Linux-syscall-note 930
and resulted in the second patch in this series.
- if a file had some form of licensing information in it, and was one
of the */uapi/* ones, it was denoted with the Linux-syscall-note if
any GPL family license was found in the file or had no licensing in
it (per prior point). Results summary:
SPDX license identifier # files
---------------------------------------------------|------
GPL-2.0 WITH Linux-syscall-note 270
GPL-2.0+ WITH Linux-syscall-note 169
((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21
((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17
LGPL-2.1+ WITH Linux-syscall-note 15
GPL-1.0+ WITH Linux-syscall-note 14
((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5
LGPL-2.0+ WITH Linux-syscall-note 4
LGPL-2.1 WITH Linux-syscall-note 3
((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3
((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1
and that resulted in the third patch in this series.
- when the two scanners agreed on the detected license(s), that became
the concluded license(s).
- when there was disagreement between the two scanners (one detected a
license but the other didn't, or they both detected different
licenses) a manual inspection of the file occurred.
- In most cases a manual inspection of the information in the file
resulted in a clear resolution of the license that should apply (and
which scanner probably needed to revisit its heuristics).
- When it was not immediately clear, the license identifier was
confirmed with lawyers working with the Linux Foundation.
- If there was any question as to the appropriate license identifier,
the file was flagged for further research and to be revisited later
in time.
In total, over 70 hours of logged manual review was done on the
spreadsheet to determine the SPDX license identifiers to apply to the
source files by Kate, Philippe, Thomas and, in some cases, confirmation
by lawyers working with the Linux Foundation.
Kate also obtained a third independent scan of the 4.13 code base from
FOSSology, and compared selected files where the other two scanners
disagreed against that SPDX file, to see if there was new insights. The
Windriver scanner is based on an older version of FOSSology in part, so
they are related.
Thomas did random spot checks in about 500 files from the spreadsheets
for the uapi headers and agreed with SPDX license identifier in the
files he inspected. For the non-uapi files Thomas did random spot checks
in about 15000 files.
In initial set of patches against 4.14-rc6, 3 files were found to have
copy/paste license identifier errors, and have been fixed to reflect the
correct identifier.
Additionally Philippe spent 10 hours this week doing a detailed manual
inspection and review of the 12,461 patched files from the initial patch
version early this week with:
- a full scancode scan run, collecting the matched texts, detected
license ids and scores
- reviewing anything where there was a license detected (about 500+
files) to ensure that the applied SPDX license was correct
- reviewing anything where there was no detection but the patch license
was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied
SPDX license was correct
This produced a worksheet with 20 files needing minor correction. This
worksheet was then exported into 3 different .csv files for the
different types of files to be modified.
These .csv files were then reviewed by Greg. Thomas wrote a script to
parse the csv files and add the proper SPDX tag to the file, in the
format that the file expected. This script was further refined by Greg
based on the output to detect more types of files automatically and to
distinguish between header and source .c files (which need different
comment types.) Finally Greg ran the script using the .csv files to
generate the patches.
Reviewed-by: Kate Stewart <kstewart@linuxfoundation.org>
Reviewed-by: Philippe Ombredanne <pombredanne@nexb.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years ago
|
|
|
// SPDX-License-Identifier: GPL-2.0
|
|
|
|
/*
|
|
|
|
* seq_buf.c
|
|
|
|
*
|
|
|
|
* Copyright (C) 2014 Red Hat Inc, Steven Rostedt <srostedt@redhat.com>
|
|
|
|
*
|
|
|
|
* The seq_buf is a handy tool that allows you to pass a descriptor around
|
|
|
|
* to a buffer that other functions can write to. It is similar to the
|
|
|
|
* seq_file functionality but has some differences.
|
|
|
|
*
|
|
|
|
* To use it, the seq_buf must be initialized with seq_buf_init().
|
|
|
|
* This will set up the counters within the descriptor. You can call
|
|
|
|
* seq_buf_init() more than once to reset the seq_buf to start
|
|
|
|
* from scratch.
|
|
|
|
*/
|
|
|
|
#include <linux/uaccess.h>
|
|
|
|
#include <linux/seq_file.h>
|
|
|
|
#include <linux/seq_buf.h>
|
|
|
|
|
|
|
|
/**
|
|
|
|
* seq_buf_can_fit - can the new data fit in the current buffer?
|
|
|
|
* @s: the seq_buf descriptor
|
|
|
|
* @len: The length to see if it can fit in the current buffer
|
|
|
|
*
|
|
|
|
* Returns true if there's enough unused space in the seq_buf buffer
|
|
|
|
* to fit the amount of new data according to @len.
|
|
|
|
*/
|
|
|
|
static bool seq_buf_can_fit(struct seq_buf *s, size_t len)
|
|
|
|
{
|
|
|
|
return s->len + len <= s->size;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* seq_buf_print_seq - move the contents of seq_buf into a seq_file
|
|
|
|
* @m: the seq_file descriptor that is the destination
|
|
|
|
* @s: the seq_buf descriptor that is the source.
|
|
|
|
*
|
|
|
|
* Returns zero on success, non zero otherwise
|
|
|
|
*/
|
|
|
|
int seq_buf_print_seq(struct seq_file *m, struct seq_buf *s)
|
|
|
|
{
|
|
|
|
unsigned int len = seq_buf_used(s);
|
|
|
|
|
|
|
|
return seq_write(m, s->buffer, len);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* seq_buf_vprintf - sequence printing of information.
|
|
|
|
* @s: seq_buf descriptor
|
|
|
|
* @fmt: printf format string
|
|
|
|
* @args: va_list of arguments from a printf() type function
|
|
|
|
*
|
|
|
|
* Writes a vnprintf() format into the sequencce buffer.
|
|
|
|
*
|
|
|
|
* Returns zero on success, -1 on overflow.
|
|
|
|
*/
|
|
|
|
int seq_buf_vprintf(struct seq_buf *s, const char *fmt, va_list args)
|
|
|
|
{
|
|
|
|
int len;
|
|
|
|
|
|
|
|
WARN_ON(s->size == 0);
|
|
|
|
|
|
|
|
if (s->len < s->size) {
|
|
|
|
len = vsnprintf(s->buffer + s->len, s->size - s->len, fmt, args);
|
seq_buf: Fix seq_buf_vprintf() truncation
In seq_buf_vprintf(), vsnprintf() is used to copy the format into the
buffer remaining in the seq_buf structure. The return of vsnprintf()
is the amount of characters written to the buffer excluding the '\0',
unless the line was truncated!
If the line copied does not fit, it is truncated, and a '\0' is added
to the end of the buffer. But in this case, '\0' is included in the length
of the line written. To know if the buffer had overflowed, the return
length will be the same as the length of the buffer passed in.
The check in seq_buf_vprintf() only checked if the length returned from
vsnprintf() would fit in the buffer, as the seq_buf_vprintf() is only
to be an all or nothing command. It either writes all the string into
the seq_buf, or none of it. If the string is truncated, the pointers
inside the seq_buf must be reset to what they were when the function was
called. This is not the case. On overflow, it copies only part of the string.
The fix is to change the overflow check to see if the length returned from
vsnprintf() is less than the length remaining in the seq_buf buffer, and not
if it is less than or equal to as it currently does. Then seq_buf_vprintf()
will know if the write from vsnpritnf() was truncated or not.
Cc: stable@vger.kernel.org
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
10 years ago
|
|
|
if (s->len + len < s->size) {
|
|
|
|
s->len += len;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
seq_buf_set_overflow(s);
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* seq_buf_printf - sequence printing of information
|
|
|
|
* @s: seq_buf descriptor
|
|
|
|
* @fmt: printf format string
|
|
|
|
*
|
|
|
|
* Writes a printf() format into the sequence buffer.
|
|
|
|
*
|
|
|
|
* Returns zero on success, -1 on overflow.
|
|
|
|
*/
|
|
|
|
int seq_buf_printf(struct seq_buf *s, const char *fmt, ...)
|
|
|
|
{
|
|
|
|
va_list ap;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
va_start(ap, fmt);
|
|
|
|
ret = seq_buf_vprintf(s, fmt, ap);
|
|
|
|
va_end(ap);
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
#ifdef CONFIG_BINARY_PRINTF
|
|
|
|
/**
|
|
|
|
* seq_buf_bprintf - Write the printf string from binary arguments
|
|
|
|
* @s: seq_buf descriptor
|
|
|
|
* @fmt: The format string for the @binary arguments
|
|
|
|
* @binary: The binary arguments for @fmt.
|
|
|
|
*
|
|
|
|
* When recording in a fast path, a printf may be recorded with just
|
|
|
|
* saving the format and the arguments as they were passed to the
|
|
|
|
* function, instead of wasting cycles converting the arguments into
|
|
|
|
* ASCII characters. Instead, the arguments are saved in a 32 bit
|
|
|
|
* word array that is defined by the format string constraints.
|
|
|
|
*
|
|
|
|
* This function will take the format and the binary array and finish
|
|
|
|
* the conversion into the ASCII string within the buffer.
|
|
|
|
*
|
|
|
|
* Returns zero on success, -1 on overflow.
|
|
|
|
*/
|
|
|
|
int seq_buf_bprintf(struct seq_buf *s, const char *fmt, const u32 *binary)
|
|
|
|
{
|
|
|
|
unsigned int len = seq_buf_buffer_left(s);
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
WARN_ON(s->size == 0);
|
|
|
|
|
|
|
|
if (s->len < s->size) {
|
|
|
|
ret = bstr_printf(s->buffer + s->len, len, fmt, binary);
|
seq_buf: Fix seq_buf_bprintf() truncation
In seq_buf_bprintf(), bstr_printf() is used to copy the format into the
buffer remaining in the seq_buf structure. The return of bstr_printf()
is the amount of characters written to the buffer excluding the '\0',
unless the line was truncated!
If the line copied does not fit, it is truncated, and a '\0' is added
to the end of the buffer. But in this case, '\0' is included in the length
of the line written. To know if the buffer had overflowed, the return
length will be the same or greater than the length of the buffer passed in.
The check in seq_buf_bprintf() only checked if the length returned from
bstr_printf() would fit in the buffer, as the seq_buf_bprintf() is only
to be an all or nothing command. It either writes all the string into
the seq_buf, or none of it. If the string is truncated, the pointers
inside the seq_buf must be reset to what they were when the function was
called. This is not the case. On overflow, it copies only part of the string.
The fix is to change the overflow check to see if the length returned from
bstr_printf() is less than the length remaining in the seq_buf buffer, and not
if it is less than or equal to as it currently does. Then seq_buf_bprintf()
will know if the write from bstr_printf() was truncated or not.
Link: http://lkml.kernel.org/r/1425500481.2712.27.camel@perches.com
Cc: stable@vger.kernel.org
Reported-by: Joe Perches <joe@perches.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
10 years ago
|
|
|
if (s->len + ret < s->size) {
|
|
|
|
s->len += ret;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
seq_buf_set_overflow(s);
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
#endif /* CONFIG_BINARY_PRINTF */
|
|
|
|
|
|
|
|
/**
|
|
|
|
* seq_buf_puts - sequence printing of simple string
|
|
|
|
* @s: seq_buf descriptor
|
|
|
|
* @str: simple string to record
|
|
|
|
*
|
|
|
|
* Copy a simple string into the sequence buffer.
|
|
|
|
*
|
|
|
|
* Returns zero on success, -1 on overflow
|
|
|
|
*/
|
|
|
|
int seq_buf_puts(struct seq_buf *s, const char *str)
|
|
|
|
{
|
|
|
|
unsigned int len = strlen(str);
|
|
|
|
|
|
|
|
WARN_ON(s->size == 0);
|
|
|
|
|
|
|
|
/* Add 1 to len for the trailing null byte which must be there */
|
|
|
|
len += 1;
|
|
|
|
|
|
|
|
if (seq_buf_can_fit(s, len)) {
|
|
|
|
memcpy(s->buffer + s->len, str, len);
|
|
|
|
/* Don't count the trailing null byte against the capacity */
|
|
|
|
s->len += len - 1;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
seq_buf_set_overflow(s);
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* seq_buf_putc - sequence printing of simple character
|
|
|
|
* @s: seq_buf descriptor
|
|
|
|
* @c: simple character to record
|
|
|
|
*
|
|
|
|
* Copy a single character into the sequence buffer.
|
|
|
|
*
|
|
|
|
* Returns zero on success, -1 on overflow
|
|
|
|
*/
|
|
|
|
int seq_buf_putc(struct seq_buf *s, unsigned char c)
|
|
|
|
{
|
|
|
|
WARN_ON(s->size == 0);
|
|
|
|
|
|
|
|
if (seq_buf_can_fit(s, 1)) {
|
|
|
|
s->buffer[s->len++] = c;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
seq_buf_set_overflow(s);
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* seq_buf_putmem - write raw data into the sequenc buffer
|
|
|
|
* @s: seq_buf descriptor
|
|
|
|
* @mem: The raw memory to copy into the buffer
|
|
|
|
* @len: The length of the raw memory to copy (in bytes)
|
|
|
|
*
|
|
|
|
* There may be cases where raw memory needs to be written into the
|
|
|
|
* buffer and a strcpy() would not work. Using this function allows
|
|
|
|
* for such cases.
|
|
|
|
*
|
|
|
|
* Returns zero on success, -1 on overflow
|
|
|
|
*/
|
|
|
|
int seq_buf_putmem(struct seq_buf *s, const void *mem, unsigned int len)
|
|
|
|
{
|
|
|
|
WARN_ON(s->size == 0);
|
|
|
|
|
|
|
|
if (seq_buf_can_fit(s, len)) {
|
|
|
|
memcpy(s->buffer + s->len, mem, len);
|
|
|
|
s->len += len;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
seq_buf_set_overflow(s);
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
#define MAX_MEMHEX_BYTES 8U
|
|
|
|
#define HEX_CHARS (MAX_MEMHEX_BYTES*2 + 1)
|
|
|
|
|
|
|
|
/**
|
|
|
|
* seq_buf_putmem_hex - write raw memory into the buffer in ASCII hex
|
|
|
|
* @s: seq_buf descriptor
|
|
|
|
* @mem: The raw memory to write its hex ASCII representation of
|
|
|
|
* @len: The length of the raw memory to copy (in bytes)
|
|
|
|
*
|
|
|
|
* This is similar to seq_buf_putmem() except instead of just copying the
|
|
|
|
* raw memory into the buffer it writes its ASCII representation of it
|
|
|
|
* in hex characters.
|
|
|
|
*
|
|
|
|
* Returns zero on success, -1 on overflow
|
|
|
|
*/
|
|
|
|
int seq_buf_putmem_hex(struct seq_buf *s, const void *mem,
|
|
|
|
unsigned int len)
|
|
|
|
{
|
|
|
|
unsigned char hex[HEX_CHARS];
|
|
|
|
const unsigned char *data = mem;
|
|
|
|
unsigned int start_len;
|
|
|
|
int i, j;
|
|
|
|
|
|
|
|
WARN_ON(s->size == 0);
|
|
|
|
|
|
|
|
while (len) {
|
|
|
|
start_len = min(len, HEX_CHARS - 1);
|
|
|
|
#ifdef __BIG_ENDIAN
|
|
|
|
for (i = 0, j = 0; i < start_len; i++) {
|
|
|
|
#else
|
|
|
|
for (i = start_len-1, j = 0; i >= 0; i--) {
|
|
|
|
#endif
|
|
|
|
hex[j++] = hex_asc_hi(data[i]);
|
|
|
|
hex[j++] = hex_asc_lo(data[i]);
|
|
|
|
}
|
|
|
|
if (WARN_ON_ONCE(j == 0 || j/2 > len))
|
|
|
|
break;
|
|
|
|
|
|
|
|
/* j increments twice per loop */
|
|
|
|
len -= j / 2;
|
|
|
|
hex[j++] = ' ';
|
|
|
|
|
|
|
|
seq_buf_putmem(s, hex, j);
|
|
|
|
if (seq_buf_has_overflowed(s))
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* seq_buf_path - copy a path into the sequence buffer
|
|
|
|
* @s: seq_buf descriptor
|
|
|
|
* @path: path to write into the sequence buffer.
|
|
|
|
* @esc: set of characters to escape in the output
|
|
|
|
*
|
|
|
|
* Write a path name into the sequence buffer.
|
|
|
|
*
|
|
|
|
* Returns the number of written bytes on success, -1 on overflow
|
|
|
|
*/
|
|
|
|
int seq_buf_path(struct seq_buf *s, const struct path *path, const char *esc)
|
|
|
|
{
|
|
|
|
char *buf;
|
|
|
|
size_t size = seq_buf_get_buf(s, &buf);
|
|
|
|
int res = -1;
|
|
|
|
|
|
|
|
WARN_ON(s->size == 0);
|
|
|
|
|
|
|
|
if (size) {
|
|
|
|
char *p = d_path(path, buf, size);
|
|
|
|
if (!IS_ERR(p)) {
|
|
|
|
char *end = mangle_path(buf, p, esc);
|
|
|
|
if (end)
|
|
|
|
res = end - buf;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
seq_buf_commit(s, res);
|
|
|
|
|
|
|
|
return res;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* seq_buf_to_user - copy the squence buffer to user space
|
|
|
|
* @s: seq_buf descriptor
|
|
|
|
* @ubuf: The userspace memory location to copy to
|
|
|
|
* @cnt: The amount to copy
|
|
|
|
*
|
|
|
|
* Copies the sequence buffer into the userspace memory pointed to
|
|
|
|
* by @ubuf. It starts from the last read position (@s->readpos)
|
|
|
|
* and writes up to @cnt characters or till it reaches the end of
|
|
|
|
* the content in the buffer (@s->len), which ever comes first.
|
|
|
|
*
|
|
|
|
* On success, it returns a positive number of the number of bytes
|
|
|
|
* it copied.
|
|
|
|
*
|
|
|
|
* On failure it returns -EBUSY if all of the content in the
|
|
|
|
* sequence has been already read, which includes nothing in the
|
|
|
|
* sequence (@s->len == @s->readpos).
|
|
|
|
*
|
|
|
|
* Returns -EFAULT if the copy to userspace fails.
|
|
|
|
*/
|
|
|
|
int seq_buf_to_user(struct seq_buf *s, char __user *ubuf, int cnt)
|
|
|
|
{
|
|
|
|
int len;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
if (!cnt)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
len = seq_buf_used(s);
|
|
|
|
|
|
|
|
if (len <= s->readpos)
|
|
|
|
return -EBUSY;
|
|
|
|
|
|
|
|
len -= s->readpos;
|
|
|
|
if (cnt > len)
|
|
|
|
cnt = len;
|
|
|
|
ret = copy_to_user(ubuf, s->buffer + s->readpos, cnt);
|
|
|
|
if (ret == cnt)
|
|
|
|
return -EFAULT;
|
|
|
|
|
|
|
|
cnt -= ret;
|
|
|
|
|
|
|
|
s->readpos += cnt;
|
|
|
|
return cnt;
|
|
|
|
}
|