diff --git a/aidl/power-libperfmgr/InteractionHandler.cpp b/aidl/power-libperfmgr/InteractionHandler.cpp index 0c28365d..9ca52a64 100644 --- a/aidl/power-libperfmgr/InteractionHandler.cpp +++ b/aidl/power-libperfmgr/InteractionHandler.cpp @@ -65,14 +65,15 @@ bool InteractionHandler::Init() { if (mState != INTERACTION_STATE_UNINITIALIZED) return true; - mIdleFd = fb_idle_open(); + int fd = fb_idle_open(); + if (fd < 0) + return false; + mIdleFd = fd; mEventFd = eventfd(0, EFD_NONBLOCK); if (mEventFd < 0) { ALOGE("Unable to create event fd (%d)", errno); - if (mIdleFd >= 0) { - close(mIdleFd); - } + close(mIdleFd); return false; } @@ -95,9 +96,7 @@ void InteractionHandler::Exit() { mThread->join(); close(mEventFd); - if (mIdleFd >= 0) { - close(mIdleFd); - } + close(mIdleFd); } void InteractionHandler::PerfLock() { @@ -213,18 +212,6 @@ void InteractionHandler::WaitForIdle(int32_t wait_ms, int32_t timeout_ms) { return; } - if (mIdleFd < 0) { - ret = poll(pfd, 1, timeout_ms); - if (ret > 0) { - ALOGV("%s: wait for duration aborted", __func__); - return; - } else if (ret < 0) { - ALOGE("%s: Error on waiting for duration (%zd)", __func__, ret); - return; - } - return; - } - ret = pread(mIdleFd, data, sizeof(data), 0); if (!ret) { ALOGE("%s: Unexpected EOF!", __func__);